reviews.llvm.orgLLVM - Wikipedia

Page Menu Phabricator Search Configure Global Search Log In All commits Restricted Dashboard Discourse Discord GitHub Project BuildBots Favorites Differential Diffusion Audit Projects Dashboards More Applications Active Repositories View All rG LLVM Github Monorepo 605fd4d77ce1: [VE] Change calling convention to follow ABI 392,888 Commits Fri, Jul 31, 6:08 PM Git rZORG LLVM Github Zorg d20a0e8ef24b: added cmake flag for Vulkan 3,363 Commits · Restricted Project Fri, Jul 31, 5:04 AM Git Recent Activity View All Today ckennelly accepted D85061: [msan] Respect no_huge_pages_for_shadow. . We could scan /proc/self/smaps for regions huge page eligibility, but that's probably brittle/annoying. Fri, Jul 31, 7:03 PM · Restricted Project MaskRay added inline comments to D84858: [llvm-libtool-darwin] Refactor ArchiveWriter . Fri, Jul 31, 6:56 PM · Restricted Project MaskRay added inline comments to D84858: [llvm-libtool-darwin] Refactor ArchiveWriter . Fri, Jul 31, 6:55 PM · Restricted Project tinti updated the diff for D85024: [llvm-objdump] Implement --prefix option . Expected to fix failed test case on Windows. Fri, Jul 31, 6:55 PM · Restricted Project ychen added a comment to D85063: [NewPM][LoopVersioning] Port LoopVersioning to NPM . Add a test case in llvm/test/Transforms/LoopVersioning/basic.ll? Where is the unit test for this (if there is any)? Fri, Jul 31, 6:54 PM · Restricted Project smeenai added inline comments to D84858: [llvm-libtool-darwin] Refactor ArchiveWriter . Fri, Jul 31, 6:48 PM · Restricted Project MaskRay added inline comments to D84858: [llvm-libtool-darwin] Refactor ArchiveWriter . Fri, Jul 31, 6:42 PM · Restricted Project kaz7 committed rG605fd4d77ce1: [VE] Change calling convention to follow ABI (authored by kaz7 ). [VE] Change calling convention to follow ABI Fri, Jul 31, 6:09 PM kaz7 closed D84581: [VE] Change calling convention to follow ABI . Fri, Jul 31, 6:09 PM · Restricted Project , Restricted Project aprantl added a comment to D84891: WIP: [Verifier] Flag dbg.declares which specify different addresses for the same fragment . Without a testcase it's not immediately obvious what this is catching. It's legal for two *different* fragments of the same variable to point to two separate allocas, I think that's the output of SROA. It's not legal for any one variable (fragment) to be described by a dbg.declare and any other instrinsic. A dbg.declare is supposed to be the only, authoritative location of a variable. So maybe the test could be even stricter. Fri, Jul 31, 5:47 PM · Restricted Project njames93 committed rG1fd2049e38da: [clang-tidy][NFC] Added convienence methods for getting optional options (authored by njames93 ). [clang-tidy][NFC] Added convienence methods for getting optional options Fri, Jul 31, 5:46 PM njames93 closed D84812: [clang-tidy][NFC] Added convienence methods for getting optional options . Fri, Jul 31, 5:46 PM · Restricted Project guiand added a comment to D83595: [Draft][MSAN] Optimize away poisoning allocas that are always written before load . It seems like collectInitializers leans heavily on the isPointerOffset function, which returns an offset if two pointers have a constant difference, nullopt if they don't. The problem here is that we can't distinguish isPointerOffset == nullopt happening because the offset is determined at runtime, or because the two pointers are completely unrelated. Fri, Jul 31, 5:42 PM · Restricted Project , Restricted Project sbc100 added a comment to D85062: [WebAssembly] GC constructor functions in otherwise unused objects . To be clear this change only relates to object files at are part of ar archives and are not part of the link? Perhaps mention that in the PR title/description. Fri, Jul 31, 5:39 PM · Restricted Project cgyurgyik requested review of D85064: [libc] Add fuzz test for strlen, memchr. . Fri, Jul 31, 5:38 PM · Restricted Project aeubanks added reviewers for D85063: [NewPM][LoopVersioning] Port LoopVersioning to NPM : ychen , asbirlea , hans , anemet , fhahn . Fri, Jul 31, 5:36 PM · Restricted Project aeubanks requested review of D85063: [NewPM][LoopVersioning] Port LoopVersioning to NPM . Fri, Jul 31, 5:34 PM · Restricted Project tinti added inline comments to D85024: [llvm-objdump] Implement --prefix option . Fri, Jul 31, 5:33 PM · Restricted Project huihuiz added a comment to D85045: [AArch64][SVE] Allow vector of pointers as legal type for masked load/store. . Thanks @paulwalker-arm for the review! I have moved the new tests into sve-masked-ldst-nonext.ll in the commit. Fri, Jul 31, 5:31 PM · Restricted Project vrnithinkumar added inline comments to D84600: [Analyzer] Support note tags for smart ptr checker . Fri, Jul 31, 5:31 PM · Restricted Project huihuiz committed rG01bfe2e49402: [AArch64][SVE] Allow vector of pointers as legal type for masked load/store. (authored by huihuiz ). [AArch64][SVE] Allow vector of pointers as legal type for masked load/store. Fri, Jul 31, 5:30 PM huihuiz closed D85045: [AArch64][SVE] Allow vector of pointers as legal type for masked load/store. . Fri, Jul 31, 5:30 PM · Restricted Project aprantl accepted D84829: [clang] Don't make ObjCIvarDecl visible twice when adding them to an implicit ObjCInterfaceDecl . Fri, Jul 31, 5:30 PM aprantl accepted D84828: [clang] Don't make synthesized accessor stub functions visible twice . All for deleting the cargo-cult code. Thanks! Fri, Jul 31, 5:29 PM eugenis added a comment to D85061: [msan] Respect no_huge_pages_for_shadow. . Testing this would be pretty hard - we'd need to touch a bunch of memory pages, and then somehow wait for the huge page daemon to merge them (or not). Fri, Jul 31, 5:28 PM · Restricted Project MaskRay abandoned D67388: Add a feature to dump dependency graph. . Fri, Jul 31, 5:27 PM · Restricted Project MaskRay commandeered D67388: Add a feature to dump dependency graph. . Closed by D82437 Fri, Jul 31, 5:27 PM · Restricted Project NoQ added inline comments to D84600: [Analyzer] Support note tags for smart ptr checker . Fri, Jul 31, 5:27 PM · Restricted Project aprantl accepted D84634: [NFC] [MIR] Document the reg state flags . Fri, Jul 31, 5:26 PM · Restricted Project MaskRay added a comment to D85061: [msan] Respect no_huge_pages_for_shadow. . Is there any way testing this? Fri, Jul 31, 5:26 PM · Restricted Project NoQ accepted D85026: [analyzer] Minor refactoring of SVal::getSubKind function . That's a fair point. Fri, Jul 31, 5:26 PM · Restricted Project MaskRay accepted D85061: [msan] Respect no_huge_pages_for_shadow. . LGTM. Fri, Jul 31, 5:25 PM · Restricted Project aprantl added inline comments to D84716: [lldb/ArchSpec] Always match simulator environment in IsEqualTo . Fri, Jul 31, 5:24 PM · Restricted Project NoQ added inline comments to D84600: [Analyzer] Support note tags for smart ptr checker . Fri, Jul 31, 5:23 PM · Restricted Project sunfish requested review of D85062: [WebAssembly] GC constructor functions in otherwise unused objects . Fri, Jul 31, 5:23 PM · Restricted Project eugenis requested review of D85061: [msan] Respect no_huge_pages_for_shadow. . Fri, Jul 31, 5:20 PM · Restricted Project rsmith committed rG234f51a65a45: Don't crash if we deserialize a pack expansion type whose pattern (authored by rsmith ). Don't crash if we deserialize a pack expansion type whose pattern Fri, Jul 31, 5:20 PM craig.topper committed rG93c678a79b0a: [X86] Simplify vpternlog immediate selection. (authored by craig.topper ). [X86] Simplify vpternlog immediate selection. Fri, Jul 31, 5:17 PM cgyurgyik committed rG1b35c4fed29d: [libc] [obvious] In strrchr, remove cast to unsigned char before (authored by cgyurgyik ). [libc] [obvious] In strrchr, remove cast to unsigned char before Fri, Jul 31, 5:16 PM NoQ accepted D85034: [analyzer] Simplified functions SVal::getAsSymbolicExpression and similar ones . *standing ovation* Fri, Jul 31, 5:10 PM · Restricted Project View All Results...